Skip to content

Use correct fields when parsing NMX-C response in nvlink-info command#1842

Merged
tmcroberts97 merged 3 commits into
NVIDIA:mainfrom
tmcroberts97:fix/nvlink-info-admin-cli
May 21, 2026
Merged

Use correct fields when parsing NMX-C response in nvlink-info command#1842
tmcroberts97 merged 3 commits into
NVIDIA:mainfrom
tmcroberts97:fix/nvlink-info-admin-cli

Conversation

@tmcroberts97
Copy link
Copy Markdown
Contributor

Use the correct fields when parsing the NMX-C response in the nvlink-info admin-cli command. Also, return an error if any of the fields aren't parsed correctly instead of pushing a default value.

Description

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Related Issues (Optional)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

Use the correct fields when parsing the NMX-C response in the
nvlink-info admin-cli command. Also, return an error if any of the
fields aren't parsed correctly instead of pushing a default value.

Signed-off-by: Thomas McRoberts <tmcroberts@nvidia.com>
@tmcroberts97 tmcroberts97 requested a review from a team as a code owner May 20, 2026 18:04
rtamma-nv and others added 2 commits May 20, 2026 15:33
Signed-off-by: Thomas McRoberts <tmcroberts@nvidia.com>
@tmcroberts97 tmcroberts97 merged commit bfd2d7b into NVIDIA:main May 21, 2026
43 checks passed
narasimhan321 pushed a commit to narasimhan321/bare-metal-manager-core that referenced this pull request May 23, 2026
…NVIDIA#1842)

Use the correct fields when parsing the NMX-C response in the
nvlink-info admin-cli command. Also, return an error if any of the
fields aren't parsed correctly instead of pushing a default value.

## Description
<!-- Describe what this PR does -->

## Type of Change
<!-- Check one that best describes this PR -->
- [ ] **Add** - New feature or capability
- [ ] **Change** - Changes in existing functionality  
- [x] **Fix** - Bug fixes
- [ ] **Remove** - Removed features or deprecated functionality
- [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.)

## Related Issues (Optional)
<!-- If applicable, provide GitHub Issue. -->

## Breaking Changes
- [ ] This PR contains breaking changes

<!-- If checked above, describe the breaking changes and migration steps
-->

## Testing
<!-- How was this tested? Check all that apply -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated  
- [x] Manual testing performed
- [ ] No testing required (docs, internal refactor, etc.)

## Additional Notes
<!-- Any additional context, deployment notes, or reviewer guidance -->

---------

Signed-off-by: Thomas McRoberts <tmcroberts@nvidia.com>
Co-authored-by: rtamma-nv <rtamma@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants